Instrument guest exec steps#246
Open
sjmiller609 wants to merge 1 commit into
Open
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: Cannot determine repository from PR information; please clarify if this PR is in the To monitor this PR anyway, reply with |
rgarcia
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note
Low Risk
Observability-only changes gated on WaitForAgent; exec and retry behavior are unchanged aside from tracing hooks.
Overview
Adds OpenTelemetry child spans around each phase of a single guest exec attempt when
WaitForAgentis set, so traces can separate agent-wait/retry time from connection setup vs. stream I/O vs. command runtime.Under the existing
guest.execparent span, new steps areguest.exec.get_conn,open_stream,send_start, andrecv_until_exit. The receive step records stdout/stderr byte counts, bytes sent, and exit code on success or failure. Step spans are not created whenWaitForAgentis zero, avoiding duplicate noise next to API-level exec spans.Tests use an in-memory span recorder to assert the full span tree and attributes on the wait path, and that no
guest.exec*spans appear without waiting. Retry tests now clean up pooled gRPC connections viaCloseConn.Reviewed by Cursor Bugbot for commit 4b6e973. Bugbot is set up for automated code reviews on this repo. Configure here.